Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add edit url to file frontmatter #1804

Merged
merged 3 commits into from
Jan 23, 2025
Merged

🔧 Add edit url to file frontmatter #1804

merged 3 commits into from
Jan 23, 2025

Conversation

fwkoch
Copy link
Collaborator

@fwkoch fwkoch commented Jan 23, 2025

This is to enable an Edit on Github button in the theme. The edit url will be computed github is provided in the frontmatter and git is available (unless edit is explicitly set to null)

See jupyter-book/myst-theme#326

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 67112bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
myst-frontmatter Patch
myst-cli Patch
myst-common Patch
myst-config Patch
myst-spec-ext Patch
mystmd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

docs/frontmatter.md Outdated Show resolved Hide resolved
@rowanc1
Copy link
Member

rowanc1 commented Jan 23, 2025

This looks good! Theme change can happen next, then we can further document.

@rowanc1 rowanc1 merged commit 00a47c4 into main Jan 23, 2025
7 checks passed
@rowanc1 rowanc1 deleted the feat/edit-url branch January 23, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants