-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add ReadTheDocs automation #982
Conversation
e602eb5
to
d8c2cc4
Compare
26a540e
to
02c8806
Compare
Any ideas on what is going on here? Why is Edit: It seems |
1e07c14
to
1ef8cfa
Compare
Ready for review. Everything seems to be working: https://beta.readthedocs.org/projects/mystmd-temp/builds/?version=1 There is one issue though, the paths and url are not relocatable, i.e. the index root is set to https://mystmd-temp--1.org.readthedocs.build/en/1/ ( For the sake of this PR, we can serve a single-version page. Navigation also seems slightly broken in that |
4e7b250
to
af8b767
Compare
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
2ffec2c
to
db69399
Compare
Indeed I have tried that, it did solve the But I figured that setting |
--execute
when building our site
#1114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we merge this one in as-is, and then continue iteration on RTD preview builds via a RTD project that's linked to this repository. Then we can consider this "done" when we get a PR preview of our documentation.
@rowanc1 does that make sense to you?
In that case when creating the RTD settings, the main website builder should be disabled so that |
@choldgraf and I are going to do some testing now in the |
- npm run build | ||
- npm run --workspace packages/mystmd link | ||
- myst --version | ||
- cd docs && BASE_URL=${READTHEDOCS_CANONICAL_URL} myst build --html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was planning on quickly dropping the BASE_URL
part here, but anyway, there are other issues to resolve with this, so can do that at that time. Also drop the bottom comment as unplanned upstream anyway
The preview is up here: The biggest issue (beyond hydration) is around the |
Yeah, both issues are on |
I will create a
mystmd-temp
slug to test if it all works as expectedCloses #968