Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataframe_parser: use pre tag for table data #763

Merged
merged 4 commits into from
Jan 3, 2023

Conversation

utkarshgupta137
Copy link
Contributor

@utkarshgupta137 utkarshgupta137 commented May 20, 2022

Description

DataFrame may contain some data which may get parsed to MathJax elements which don't play nicely with tables & may not properly represent the actual dataframe data. To avoid this, we can wrap the data in <th>/<td> tags in <pre>.
I've also added a couple of style unsets to fix formatting issues.

Checklist

  • Wrote a description of my changes above
  • Formatted my code with black
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Added or modified unit tests to reflect my changes
  • Manually tested with a notebook
  • If adding a feature, there is an example notebook and/or documentation in the README.md file

@devstein
Copy link
Collaborator

devstein commented Dec 31, 2022

Hey @utkarshgupta137 thanks for making a PR. Do you have a code snippet I can use for manual testing?

@utkarshgupta137
Copy link
Contributor Author

Hey @utkarshgupta137 thanks for making a PR. Do you have a code snippet I can use for manual testing?

I've switched jobs & don't have access to a Spark Cluster, but you should be able to reproduce this with non-ASCII text. AFAIR Indic languages were causing issues.

@devstein devstein merged commit ee8d6f4 into jupyter-incubator:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants