Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility of under-described diagnostics #743

Closed
bollwyvl opened this issue Jan 2, 2022 · 1 comment
Closed

Improve visibility of under-described diagnostics #743

bollwyvl opened this issue Jan 2, 2022 · 1 comment

Comments

@bollwyvl
Copy link
Collaborator

bollwyvl commented Jan 2, 2022

Elevator Pitch

Allow expanding zero-sized diagnostics so they are visible with in-line editor marks (e.g. squiggle underlines).

Motivation

Some servers (or there linters), such as those added in #724, provide diagnostics in-editor that we don't display because they have zero size. We can still see them in the diagnostic panel.

While expanding them to at least one character would make them somewhat visible, it may be preferrable for them to be even bigger, either the rest of the line or the entire line.

Design Ideas

Add a setting, expandZeroWidthDiagnostics: int. The default value could be 1, while, ideally, a -1 would expand to the end of the line.

Alternatives

CodeMirror 5 offers some other marks including:

  • gutters (like line numbers and breakpoints)
    • at present these are kind of perilous as debugger/lineNumbers are managed rather coarsely
  • line widgets
    • thes put entire lines above/below the line in question

These could be explored as well, and might be preferable for other users and use cases.

@krassowski
Copy link
Member

Closing, as in jupyterlab-lsp 5.0 there is a dedicated triangle indicator for zero-sized diagnostics now thanks to CodeMirror 6 linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants