-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Robot Framework language server (again) #724
Add Robot Framework language server (again) #724
Conversation
👈 Launch a binder notebook on branch bollwyvl/jupyterlab-lsp/gh-332-add-rflsp-again |
Still need to test in |
Ah, all of the diagnostics I've seen have zero width! Really surprised me! I guess some options (not to be fixed on this issue):
|
or to 1 character? I would like this regardless of gutters. |
Sure, perhaps expandZeroWidthDiagnostics with a default of 0, preserving
existing behavior, while 1 would be one character, and -1 could go to the
end of the line.
|
If that becomes a setting, I happy for it to have a non-zero default. |
Is it still WIP, or can we merge? |
I'll merge upstream and take another look, but probably good to go, no
substantive further changes planned...
|
I've
If this passes, it's probably ready to go. |
Thanks for the binder assist, trying right now. I put the user check in because i test (the rest of) |
Ugh, the "magic" Additionally: it looks like something we're pulling in is forcing us down to jupyterlab 3.1.x, which is good for testing, i guess, but poor for picking up more recent features and bug fixes. It also means that the retrolab we're getting is fairly outdated at this point... I guess that's academic, as we'll want to start testing with |
Ok, had a go at it on binder. Everything seems mostly working except:
Note that i can't reproduce these issues locally. We could put completion under test, but once again, at some point there's only so much we can control. conda-lock for reference: jupyter-lsp-binder.conda.lock.txt |
works for me on binder; the problem might be that it is case sensitive by default; we might want to allow servers specs to override the defaults (and have a default option for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
References
Code changes
robotframework-pabot (interested to see the intersection of this with other tools)npm
onesoverrides.json
to the binderUser-facing changes
Backwards-incompatible changes
Chores