Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve traitlets type warnings, lint, remove six #1015

Merged
merged 3 commits into from
Nov 25, 2023
Merged

Resolve traitlets type warnings, lint, remove six #1015

merged 3 commits into from
Nov 25, 2023

Conversation

krassowski
Copy link
Member

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/fix-linting-blocking-ci

@krassowski
Copy link
Member Author

Looks like bash-language-server needs pinning or updating startup script as it is timing out.

@krassowski
Copy link
Member Author

Or maybe the typing warnings are right and this is just one of the breaking changes in latest traitlets?

@krassowski
Copy link
Member Author

Merging as it unblocks CI. The pypy smoke failure is tracked in #1018.

@krassowski krassowski merged commit ebcb064 into jupyter-lsp:main Nov 25, 2023
16 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krassowski