Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overrides priority #1027

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Fix overrides priority #1027

merged 2 commits into from
Nov 26, 2023

Conversation

krassowski
Copy link
Member

References

Follow-up to #919

Code changes

Prefer user-set priority over the overrides and defaults. Prefer overrides over defaults.

User-facing changes

priority can be changed from settings when it was pre-set with overrides.json.

Backwards-incompatible changes

None

@krassowski krassowski added the bug Something isn't working label Nov 26, 2023
@github-actions GitHub Actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/fix-overrides-priority

@krassowski krassowski merged commit 7c36fb2 into jupyter-lsp:main Nov 26, 2023
17 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krassowski