Fix settings reconciliation for nested properties #1051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #1047
Code changes
pyright's
python.analysis.diagnosticSeverityOverrides
is a bit different from most settings because it is an object.Prior to these PR we were allowing both dotted and nested specification of settings, and always normalized to the fully dotted notation. However, the settings schema for
python.analysis.diagnosticSeverityOverrides
was defined as an object, and UI settings were reverting it to an object leading to conflicts.This PR:
jest
tests (some code gets extracted to a static method to make it easier to test)rank
andconfiguration
which are now only set on a copy where neededUser-facing changes
python.analysis.diagnosticSeverityOverrides
can be configured inoverrides.json
or changed in settings without conflicts upon reloading JuypterLab.Backwards-incompatible changes
None