Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix websocket handler and remove spurious config for old notebook server #1069

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Fix websocket handler and remove spurious config for old notebook server #1069

merged 3 commits into from
Mar 5, 2024

Conversation

krassowski
Copy link
Member

References

Code changes

  • Use JupyterHandler with WebsocketMixin as websocket is not an JSON API handler
  • Remove spurious config for old notebook server

User-facing changes

Works with latest jupyter-sever

Backwards-incompatible changes

None

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/fix-websocket-and-spurious-notebook-json

@krassowski krassowski merged commit 71c8e0c into jupyter-lsp:main Mar 5, 2024
24 checks passed
@bollwyvl
Copy link
Collaborator

bollwyvl commented Mar 5, 2024

I see this went out as a 2.2.4, but no sdist is showing up here:

@krassowski
Copy link
Member Author

Thanks for the catch @bollwyvl, fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@krassowski @bollwyvl