Remove note about language server fork #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Not all changes were merged but indeed for now it's better to remove this note |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding of #272 (comment) is that these changes how now been merged into the
python-lspconda package and there is no need to install the forked language server separately, is this correct?Does that mean that the recommended way to install
jupyterlab-lspincluding all the speed-ups is just:And there is no need to disable Jedi, since the updates to the pylsp also improved the slow Jedi calls?
I have some issues with completion speed and can open a ticket with more info, but I just wanted to make sure that I followed the recommended installation procedure first.