Adds releaser #10
Merged
Adds releaser #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
Jun 1, 2023
| uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 | ||
| - name: Install Dependencies | ||
| run: | | ||
| pip install -e . |
There was a problem hiding this comment.
Normally it would be better to remove this step as it is not needed anymore with releaser v2.
There was a problem hiding this comment.
Having a pip install -e . only in the check release workflow but not in the "Publish Release" workflow (the one used to do the real release) can add unexpected side effects (some dev dependencies missing in the actual release workflow.
hbcarlos
added a commit
to hbcarlos/ipylgbst
that referenced
this pull request
Jun 1, 2023
hbcarlos
added a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.