Skip to content

Commit

Permalink
Make RemoteKernelManager more independent
Browse files Browse the repository at this point in the history
Make RemoteKernelManager (RKM) able to be run without a (grand)parent
EnterpriseGatewayApp (EGA) instance so it can be used by nbclient.

The config which RKM with EGA was being referred to using traitlet
lineage like `self.parent.parent.property_name`. Change both to inherit
from a Configurable mixin which contains all of EGA's previous config.
Link the attributes of the RKM instance with EGA if available to keep
old behaviour.

Modify other properties RKM uses that are not traits to become
`@property`s which fall back to sane defaults if running independently.

Change RKM to be able to generate a kernel id if necessary. Change
ProcessProxy to use provided kernel ids. Move kernel id generation
logic out of RemoteMappingKernelManager.

Resolves #803
  • Loading branch information
golf-player committed Apr 28, 2020
1 parent c594cd9 commit 28bafda
Show file tree
Hide file tree
Showing 5 changed files with 522 additions and 459 deletions.
Loading

0 comments on commit 28bafda

Please sign in to comment.