Prometheus http and kernel startup/shutdown metrics #1377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is taking on #731.
The
jupyter_server
already ships with aPrometheusMetricsHandler
, however, that handler inherits fromJupyterHandler
, which requires authentication. The enterprise gateway project doesn't integrate with that method of authentication, therefore I added separate handler to serve the metrics.I've included 3 metrics in the initial implementation:
In terms of configuration, I've included the
EG_METRICS_PREFIX
environment variable for now, similar to how other configurations for the process proxies are set.Sample responses from the /metrics endpoint