Zmq port setting #698
Merged
Zmq port setting #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 27, 2019 16:34
kevin-bates
reviewed
Jun 27, 2019
Member
kevin-bates
left a comment
kevin-bates
left a comment
There was a problem hiding this comment.
This is great - thank you! I just had a comment relative to naming and units.
docs/source/config-options.md
Outdated
| Default: 30000 | ||
| Specifies the value of ws_ping_interval that is being used for websocket | ||
| ping pong mechanism in ZMQ Port Handler from notebook server. | ||
| (NOTEBOOK_ZMQ_PORT_PING_INTERVAL env var) |
Member
There was a problem hiding this comment.
I'd prefer we follow the naming (and units) convention that @esevan introduced in jupyter/nb2kg#29. Let's call the option ws_ping_interval (with the help string indicating seconds) and the env variable EG_WS_PING_INTERVAL_SECS (defaulting to 30), then expand to ms on usage.
I don't think we need to mention ZMQ since that corresponds more closely to the (multiple) ZMQ ports - we're really pinging the (single) WS port.
…tead of milliseconds
IMAM9AIS
commented
Jul 1, 2019
Contributor
Author
IMAM9AIS
left a comment
IMAM9AIS
left a comment
There was a problem hiding this comment.
Changes made according to comments.
added 2 commits
July 1, 2019 11:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- Adding option to set ws_ping_interval variable for notebook server usages.