Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge jupyterlab-kernel-usage #163
Merge jupyterlab-kernel-usage #163
Changes from 47 commits
51a9667
47d344e
7d6d580
9a7f312
f8831be
0b75795
4130bb6
fb853b5
c502e13
fc3c993
e7d1816
36d46b5
9615ee3
0344355
659e1b7
9f8d62b
82a8389
cfe4033
14ae0ee
966d6f5
eb33ff9
0444216
35eae6c
c24ad0c
80d7dc0
38e4a50
b98c9f8
7ab05a4
17f53e0
c2a81ad
ba84246
193c6a3
b22e7f8
f9e0a04
4970166
77a67e2
683b470
27d392f
74a391c
1a28826
22f4c31
0bc37bf
b63f052
657b727
6703e02
640c7c4
ec56106
9bfbcb5
22d4e68
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these comments needed now that the files live in the same repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like
memoryUsage.tsx
can now reuse things fromformat.ts
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to pass these strings through the translator.