-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry patch #457
Merged
Merged
Telemetry patch #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32a7d3a
to
a0718a8
Compare
dlqqq
requested changes
Oct 31, 2023
dlqqq
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! The doc comment was forgotten, but now that the implementation is obviously a no-op, I think the intent is sufficiently clear.
3coins
added a commit
to 3coins/jupyter-scheduler
that referenced
this pull request
Oct 31, 2023
* Moved event logger handler up the stack. * Fixed lint errors * Combined handler, and plugin. * Fixed lint errors * separate launcher command and rename show-notebook-jobs (#3) --------- Co-authored-by: david qiu <david@qiu.dev>
3coins
added a commit
that referenced
this pull request
Oct 31, 2023
* Moved event logger handler up the stack. * Fixed lint errors * Combined handler, and plugin. * Fixed lint errors * separate launcher command and rename show-notebook-jobs (#3) --------- Co-authored-by: david qiu <david@qiu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the event logger handler up in the stack to capture launcher, context menu and notebook header events.