Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax fsspec and pytz version pins allowing latest versions #557

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

andrii-i
Copy link
Collaborator

@andrii-i andrii-i commented Nov 12, 2024

References

Code changes

Relax fsspec and pytz version pins allowing latest versions

User-facing changes

No UI changes, users are able to install different versions of fsspec and pytz within the pinned versions range instead of only one pinned version. As a result Jupyter Scheduler can be installed in the same environment as packages that depend on new versions of fsspec and pytz such as s3fs.

Backwards-incompatible changes

None

Testing

On top of automated pytest tests that cover file copying and download (fsspec) I have manually tested main user flows: creating a job, job definition with different schedules, with and without inclusion of input folder.

@andrii-i andrii-i added maintenance Maintenance/CI tasks dependencies Pull requests that update a dependency file labels Nov 12, 2024
@andrii-i andrii-i changed the title Relax fsspec and pytz version pin allowing latest versions Relax fsspec and pytz version pins allowing latest versions Nov 12, 2024
@andrii-i andrii-i marked this pull request as ready for review November 12, 2024 00:51
Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@andrii-i andrii-i merged commit 5248546 into jupyter-server:main Nov 12, 2024
12 checks passed
@andrii-i andrii-i deleted the bump-fsspec-pytz branch November 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Maintenance/CI tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fsspec 2024 Remove pins on specific (and old) versions of pytz and fsspec
2 participants