Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step N to actions to make it easier #324

Merged
merged 1 commit into from
May 19, 2022

Conversation

wolfv
Copy link
Contributor

@wolfv wolfv commented May 19, 2022

No description provided.

@wolfv
Copy link
Contributor Author

wolfv commented May 19, 2022

Something else I was wondering about: in teh since field, does the user have to enter v0.1.2? Or would 0.1.2 also work? Because IIUC then in since we expect a v prefix, but in the version we expect it without a v?

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #324 (2d4306f) into main (02418b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files          19       19           
  Lines        2555     2555           
  Branches      336      336           
=======================================
  Hits         2143     2143           
  Misses        296      296           
  Partials      116      116           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02418b2...2d4306f. Read the comment docs.

@blink1073
Copy link
Contributor

Since is looking for an actual tag, so whatever the tag is named.

@blink1073 blink1073 added the documentation Improvements or additions to documentation label May 19, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 21a39f5 into jupyter-server:main May 19, 2022
@wolfv
Copy link
Contributor Author

wolfv commented May 19, 2022

yeah, there is just the discrepancy between the version and the tag. version wants to be without v and tag with v, right? I was just thinking we could make both accept either v<VERSION> or <VERSION> or clearly state in the description which one is expected.

@blink1073
Copy link
Contributor

blink1073 commented May 19, 2022

The since parameter is used by github-activity, which only operates on tags. We could potentially check for the existence of a tag and add/remove the leading v. We do use the same language as github-activity for the docs: "date or git reference".

@wolfv wolfv deleted the step_names branch May 19, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants