Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the last line of the npm pack command #37

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 21, 2021

To fetch the name of the npm tarball, which should be the last statement of the npm pack output.

As noticed in jupyterlab/extension-cookiecutter-ts#162 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021

Codecov Report

Merging #37 (3f99e3a) into master (9129099) will decrease coverage by 0.11%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   88.51%   88.39%   -0.12%     
==========================================
  Files          15       15              
  Lines        1715     1724       +9     
  Branches      205      208       +3     
==========================================
+ Hits         1518     1524       +6     
- Misses        122      124       +2     
- Partials       75       76       +1     
Impacted Files Coverage Δ
jupyter_releaser/lib.py 75.89% <62.50%> (-0.48%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/npm.py 80.91% <100.00%> (+0.29%) ⬆️
jupyter_releaser/util.py 85.00% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cba7bf7...3f99e3a. Read the comment docs.

@blink1073 blink1073 added this to the 0.1 milestone Jun 22, 2021
@blink1073 blink1073 added the bug Something isn't working label Jun 22, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants