Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish-release #378

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Conversation

fcollonval
Copy link
Member

This fixes is based on using the new version to release JLab 3.4.7:

  • target not pass to publish-release
    Should we pass steps_to_skip too? It seems not as there is only one step - so probably that input should be remove from standalone workflow Publish Release
  • metadata.json was not ignored from the sha check loop

I created a constant storing metadata.json in util.py.

@codecov-commenter
Copy link

Codecov Report

Merging #378 (3124baf) into main (0ca050b) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   82.57%   82.58%           
=======================================
  Files          21       21           
  Lines        2887     2888    +1     
  Branches      382      382           
=======================================
+ Hits         2384     2385    +1     
  Misses        364      364           
  Partials      139      139           
Impacted Files Coverage Δ
jupyter_releaser/util.py 70.50% <33.33%> (+0.06%) ⬆️
jupyter_releaser/lib.py 80.82% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blink1073 blink1073 added the bug Something isn't working label Sep 13, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit a30d0d2 into jupyter-server:main Sep 13, 2022
@fcollonval fcollonval deleted the fix/publish-release branch September 13, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants