Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up handling of draft release metadata #387

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Sep 16, 2022

Fixes #384

Also adds logging for the values, to help diagnosing things like #385

@blink1073 blink1073 added the bug Something isn't working label Sep 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2022

Codecov Report

Base: 82.40% // Head: 82.51% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (c0093c0) compared to base (7436386).
Patch coverage: 72.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   82.40%   82.51%   +0.10%     
==========================================
  Files          21       21              
  Lines        2899     2899              
  Branches      384      380       -4     
==========================================
+ Hits         2389     2392       +3     
- Misses        371      373       +2     
+ Partials      139      134       -5     
Impacted Files Coverage Δ
jupyter_releaser/cli.py 89.86% <71.42%> (-1.05%) ⬇️
jupyter_releaser/util.py 71.42% <75.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 merged commit 71a8bd6 into jupyter-server:main Sep 16, 2022
@blink1073 blink1073 deleted the no-required-tag branch September 16, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should not require an existing tag
2 participants