Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't tag private package or pkg without version #531

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

fcollonval
Copy link
Member

Bug seen in https://github.com/jupyter/nbdime/actions/runs/6523856857/job/17714912280?pr=710 where one of the package is private and does not have a version.

@fcollonval fcollonval added the bug Something isn't working label Oct 15, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blink1073 blink1073 enabled auto-merge (squash) October 17, 2023 01:06
@blink1073 blink1073 merged commit be0c23e into jupyter-server:main Oct 17, 2023
@fcollonval fcollonval deleted the fix/tag-workspace branch October 17, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants