Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the tag format customization #536

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Allow the tag format customization #536

merged 2 commits into from
Nov 20, 2023

Conversation

fcollonval
Copy link
Member

This has been seen by @vidartf in jupyter/nbdime#659 (comment)

It add the option tag format to allow commands make use of the tag name.

@krassowski krassowski mentioned this pull request Nov 17, 2023
Closed
@fcollonval fcollonval added the enhancement New feature or request label Nov 20, 2023
fcollonval
fcollonval commented Nov 20, 2023
View reviewed changes
Copy link
Member Author

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to test the new feat' with nbdime

@fcollonval fcollonval merged commit cb677f5 into jupyter-server:main Nov 20, 2023
19 of 20 checks passed
@fcollonval fcollonval deleted the fix/tag-format branch November 20, 2023 08:50
@vidartf vidartf mentioned this pull request Nov 20, 2023
Closed
@fcollonval
Copy link
Member Author

I can confirm this works as accepted - tested on nbdime https://github.com/jupyter/nbdime/actions/runs/6929040800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fcollonval