Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to disable admin user check via flag #559

Merged
merged 5 commits into from
Mar 2, 2024
Merged

Add ability to disable admin user check via flag #559

merged 5 commits into from
Mar 2, 2024

Conversation

ElioDiNino
Copy link
Contributor

@ElioDiNino ElioDiNino commented Mar 1, 2024 •
edited
Loading

  • Added the flag logic into prepare_environment
  • Modified the applicable actions as a way of exposing this option to users (since it didn't seem applicable to add it to the CLI arguments)
  • Removed disallowed type input here

Happy to take feedback but I have tested using my changes on a private repo and things work as expected. I would appreciate a new tag being created once merged.

@welcome Welcome
Copy link

welcome bot commented Mar 1, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@ElioDiNino ElioDiNino mentioned this pull request Mar 1, 2024
Closed
blink1073
blink1073 suggested changes Mar 2, 2024
View reviewed changes
.github/actions/prep-release/action.yml
@@ -24,13 +24,16 @@ inputs:
silent:
description: "Set a placeholder in the changelog and don't publish the release."
required: false
type: boolean
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this was an unintended removal?

Copy link
Contributor Author

@ElioDiNino ElioDiNino Mar 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah that was on purpose. Types aren't supported for action inputs (reference here) and the GitHub actions extension in VS Code was complaining about it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, thank you!

@blink1073 blink1073 added the enhancement New feature or request label Mar 2, 2024
@blink1073 blink1073 changed the title feat: ability to disable admin user check via flag Add ability to disable admin user check via flag Mar 2, 2024
@blink1073 blink1073 enabled auto-merge (squash) March 2, 2024 13:32
@blink1073 blink1073 merged commit 58a343c into jupyter-server:main Mar 2, 2024
20 of 23 checks passed
@blink1073
Copy link
Contributor

I'll make a release with this on Monday, thanks again!

@welcome Welcome
Copy link

welcome bot commented Mar 2, 2024

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@ElioDiNino
Copy link
Contributor Author

I'll make a release with this on Monday, thanks again!

Great to hear! No problem, glad to contribute 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElioDiNino @blink1073