Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of default version bump #57

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

blink1073
Copy link
Contributor

Provide reasonable defaults for version bump but allow it to be overridden.
Needed for jupyterlab/jupyterlab#10340 (jupyterlab/jupyterlab#10340)

@blink1073 blink1073 added the bug Something isn't working label Jul 6, 2021
@blink1073 blink1073 added this to the 0.1 milestone Jul 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #57 (0678061) into master (9129099) will decrease coverage by 0.64%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   88.51%   87.86%   -0.65%     
==========================================
  Files          15       15              
  Lines        1715     1755      +40     
  Branches      205      215      +10     
==========================================
+ Hits         1518     1542      +24     
- Misses        122      132      +10     
- Partials       75       81       +6     
Impacted Files Coverage Δ
jupyter_releaser/util.py 82.19% <37.50%> (-2.71%) ⬇️
jupyter_releaser/lib.py 75.29% <66.66%> (-1.07%) ⬇️
jupyter_releaser/npm.py 78.83% <70.00%> (-1.79%) ⬇️
jupyter_releaser/tests/test_cli.py 97.64% <91.66%> (-0.20%) ⬇️
jupyter_releaser/__init__.py 100.00% <100.00%> (ø)
jupyter_releaser/cli.py 92.37% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38f772b...0678061. Read the comment docs.

@blink1073 blink1073 merged commit 7bdc7f8 into jupyter-server:master Jul 6, 2021
@blink1073 blink1073 deleted the fix-default-bump branch July 6, 2021 17:02
@blink1073 blink1073 mentioned this pull request Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants