Skip to content

Commit

Permalink
Due to bad typing of kwargs it things that env is a str
Browse files Browse the repository at this point in the history
but in fact it in general should be a dict
  • Loading branch information
krassowski committed Jul 10, 2024
1 parent 8963d2f commit a8b4bb9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jupyter_server/services/kernels/kernelmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ async def _async_start_kernel( # type:ignore[override]
self.log.debug(
"Kernel args (excluding env): %r", {k: v for k, v in kwargs.items() if k != "env"}
)
env = kwargs.get("env", None)
env = kwargs.get("env", None) # type:ignore[unreachable]
if env and isinstance(env, dict):
self.log.debug("Kernel argument 'env' passed with: %r", list(env.keys()))

Expand Down

0 comments on commit a8b4bb9

Please sign in to comment.