Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in warning message #1158

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Dec 29, 2022

The source code permalink provided in here was broken, likeley due to force pushes in the PR (#671) adding the comment.

@property
def identity_provider(self):
if "identity_provider" not in self.settings:
warnings.warn(
"The Tornado web application does not have an 'identity_provider' defined "
"in its settings. In future releases of jupyter_server, this will "
"be a required key for all subclasses of `JupyterHandler`. For an "
"example, see the jupyter_server source code for how to "
"add an identity provider to the tornado settings: "
"https://github.com/jupyter-server/jupyter_server/blob/"
"aa8fd8b3faf37466eeb99689d5555314c5bf6640/jupyter_server/serverapp.py"
"#L253",
)

I'm updating it to reference v2.0.0 instead, which also helps the reader understand when in time this message refers to. Specifically to the first line in this code block:

if identity_provider is None:
warnings.warn(
"identity_provider unspecified. Using default IdentityProvider."
" Specify an identity_provider to avoid this message.",
RuntimeWarning,
stacklevel=2,
)
identity_provider = IdentityProvider(parent=jupyter_app)

@welcome
Copy link

welcome bot commented Dec 29, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 79.96% // Head: 79.87% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (06bb24f) compared to base (851db61).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
- Coverage   79.96%   79.87%   -0.09%     
==========================================
  Files          68       68              
  Lines        8099     8099              
  Branches     1601     1601              
==========================================
- Hits         6476     6469       -7     
- Misses       1201     1206       +5     
- Partials      422      424       +2     
Impacted Files Coverage Δ
jupyter_server/base/handlers.py 78.82% <ø> (ø)
...ter_server/services/kernels/connection/channels.py 58.59% <0.00%> (-1.11%) ⬇️
jupyter_server/serverapp.py 80.17% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @consideRatio !

@davidbrochart davidbrochart merged commit a3a44e6 into jupyter-server:main Dec 29, 2022
@welcome
Copy link

welcome bot commented Dec 29, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants