Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove travis and appveyor build #148

Merged
merged 3 commits into from
Mar 5, 2020

Conversation

echarles
Copy link
Member

@echarles echarles commented Dec 3, 2019

Let's wait a bit to have full confidence in github actions, then let's remove travis build.

@echarles echarles added this to the 0.3.0 Release milestone Dec 3, 2019
@kevin-bates
Copy link
Member

This looks good.

Should the same fate come of appveyor as well since GH actions run Windows servers?
I would recommend an indicator in the title that indicates not to merge, perhaps either [WIP] or [DO NOT MERGE].

@echarles echarles changed the title Remove travis build [DO NOT MERGE].Remove travis build Dec 3, 2019
@echarles
Copy link
Member Author

echarles commented Dec 3, 2019

I/we have less access to windows (which is server 2019 for github actions) and prefer having a fallback in case of failure to see how it behaves on other windows flavors.

@echarles echarles changed the title [DO NOT MERGE].Remove travis build [DO NOT MERGE] Remove travis build Dec 3, 2019
@echarles
Copy link
Member Author

@kevin-bates @Zsailer any objection to process with this to remove travis and appveyor, see kevin-bates#1 ?

@echarles echarles changed the title [DO NOT MERGE] Remove travis build Remove travis and appveyor build Mar 3, 2020
@echarles
Copy link
Member Author

echarles commented Mar 3, 2020

As discussed during the server meeting, this PR remove now travis and appveyor CI build.

@Zsailer
Copy link
Member

Zsailer commented Mar 3, 2020

Let's wait until Thursday's meeting to merge. I'm stoked about this! 😎

@Zsailer Zsailer merged commit d84d52a into jupyter-server:master Mar 5, 2020
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* WIP: initial extension implementation

* add server extension

* link frontend and server extension

* refactor JS code

* disconnect the signal properly

* clean up and add testing

* fix disconnect

* formatting

Co-authored-by: Steven Silvester <ssilvester@apple.com>
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants