-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pytest11 entrypoint and plugin, require tornado 6.1, remove asyncio patch, CI work #339
Changes from 26 commits
3617344
ec6a9c6
f35144d
c076f84
d7709fa
2a3a2a0
b96c939
933b4f5
20ec9ec
d925e67
fd94f12
3c99dff
02579a7
47f07a4
ba40f81
d026e83
b86e72d
631e075
0d0ac3c
8694e53
20816c4
0e8a00f
480d6d6
a0640b3
da0fef5
e09ba05
2ce063a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,11 +34,14 @@ def add_data_files(path): | |
version = VERSION, | ||
description = 'Jupyter Server Example', | ||
long_description = open('README.md').read(), | ||
python_requires = '>=3.5', | ||
python_requires = '>=3.6', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ☠️ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess I'm not following the skull & crossbones commentary here, sorry about that. The change seems fine. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just meant 3.5 is EOL! |
||
install_requires = [ | ||
'jupyter_server', | ||
'jinja2', | ||
], | ||
extras_require = { | ||
'test': ['pytest-jupyter'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not strictly required, but if the example is supposed to be illustrative... |
||
}, | ||
include_package_data=True, | ||
cmdclass = cmdclass, | ||
entry_points = { | ||
|
@@ -52,4 +55,4 @@ def add_data_files(path): | |
|
||
|
||
if __name__ == '__main__': | ||
setup(**setup_args) | ||
setup(**setup_args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - thanks.