Use kernel_id for new kernel if it doesn't exist in MappingKernelManager.start_kernel #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #403. This change aligns the implementation of
MappingKernelManager.start_kernel
with its docstring.It is worth mentioning that in the API Doc, there is currently no method for starting a kernel by specifying a
kernel_id
. As such, no changes are made tojupyter_server/tests/services/kernels/test_api.py
. Nevertheless, this change provides a possibility to support such functionality if that is required in future.