Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Downstream Packages #528

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

blink1073
Copy link
Contributor

Ensure that local changes are compatible with prerelease versions of downstream packages
Similar to the workflow used in traitlets.

@blink1073 blink1073 added this to the 1.9 milestone May 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #528 (927cd82) into master (abaa8cd) will decrease coverage by 1.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   77.78%   76.29%   -1.50%     
==========================================
  Files         106      110       +4     
  Lines        9103     9809     +706     
  Branches      971     1067      +96     
==========================================
+ Hits         7081     7484     +403     
- Misses       1674     1944     +270     
- Partials      348      381      +33     
Impacted Files Coverage Δ
jupyter_server/tests/conftest.py 78.57% <0.00%> (-21.43%) ⬇️
jupyter_server/gateway/managers.py 60.00% <0.00%> (-16.84%) ⬇️
jupyter_server/_version.py 87.50% <0.00%> (-12.50%) ⬇️
jupyter_server/__main__.py 66.66% <0.00%> (-8.34%) ⬇️
jupyter_server/base/handlers.py 63.91% <0.00%> (-4.33%) ⬇️
jupyter_server/serverapp.py 64.88% <0.00%> (-1.96%) ⬇️
jupyter_server/files/handlers.py 29.16% <0.00%> (-1.95%) ⬇️
jupyter_server/tests/services/sessions/test_api.py 98.85% <0.00%> (-1.15%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 80.07% <0.00%> (-1.03%) ⬇️
jupyter_server/pytest_plugin.py 90.76% <0.00%> (-0.96%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abaa8cd...927cd82. Read the comment docs.

Copy link
Member

@mwakaba2 mwakaba2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blink1073 blink1073 merged commit 19ab0a9 into jupyter-server:master May 26, 2021
@blink1073 blink1073 deleted the test-downstream branch May 26, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants