-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to flit #823
Switch to flit #823
Conversation
Codecov Report
@@ Coverage Diff @@
## main #823 +/- ##
==========================================
+ Coverage 70.20% 70.24% +0.04%
==========================================
Files 63 63
Lines 7480 7480
Branches 1253 1253
==========================================
+ Hits 5251 5254 +3
+ Misses 1849 1843 -6
- Partials 380 383 +3
Continue to review full report at Codecov.
|
Wow, this is beautiful! Moving everything from setup.py and setup.cfg into the single file, pyproject.toml, so so clean. Also, the way flit handles the dynamic version is nice. The whole thing is quite readable. Thank you, @blink1073, for doing this clean up. This looks good to me. Is this ready to go? |
Yup. 😃 |
Fixes #796
Used
ini2toml
to do the heavy lifting.Depends on jupyter-server/jupyter_releaser#308 for a fix to nested resource paths checking.