Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Change test domain from *.jupyter.com/* to *.jupyter.org/* #853

Merged
merged 1 commit into from
May 23, 2022

Conversation

Sync271
Copy link
Contributor

@Sync271 Sync271 commented May 22, 2022

Closes #852
Chose to go with jupyter.org over example.com because event.mock.jupyter.org/message felt like it makes more sense.
Let me know if you guys think otherwise and I'll be happy to change.

@welcome
Copy link

welcome bot commented May 22, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2022

Codecov Report

Merging #853 (2455944) into main (7a0080c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   70.12%   70.12%           
=======================================
  Files          65       65           
  Lines        7621     7621           
  Branches     1268     1268           
=======================================
  Hits         5344     5344           
  Misses       1895     1895           
  Partials      382      382           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a0080c...2455944. Read the comment docs.

@Sync271 Sync271 changed the title Change test domain from *.jupyter.com/* to *.jupyter.org/* [Bug] Change test domain from *.jupyter.com/* to *.jupyter.org/* May 23, 2022
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Zsailer Zsailer merged commit 04c901a into jupyter-server:main May 23, 2022
@welcome
Copy link

welcome bot commented May 23, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about mock schema domain names
3 participants