Applied fix for secure writes in non-enlgish windows that was added to jupyer_client

[MSeal]

See jupyter/jupyter_client#478 for details, but this should be included in the next release.

[MSeal]

@rgbkrk @rolweber FYI

[kevin-bates]

Thanks for dealing with this @MSeal!

Is there any reason we can't switch to using the functions from jupyter_client (5.3.3)? Ideally, as the #TODO points out, we want these in jupyter_core but that's probably a different move.

((Note: If/when we switch to using the jupyter_kernel_mgmt stuff jupyter_client goes away but we'll need to update the spec kernel provider here.))

[MSeal]

@kevin-bates You likely want to either copy the functions -- or help get someone to merge jupyter/jupyter_core#163 so it's available from core :)

There was a security advisory that some internal secret files weren't guaranteed to be saved to permission secured files. In most cases the default behavior is fine but in some setups it exposes files to be read / written by adjacent (or anonymous) users.

[MSeal]

In the meanwhile loading it from jupyter_client is probably fine if you already have the dependency added anyway.

[kevin-bates]

@MSeal - dang, I didn't realize I hadn't been watching core - thank you!

[Zsailer]

Thanks, @MSeal! LGTM.

[rolweber]

lgtm

[rolweber]

I'll merge this as-is. If we switch to using the function from jupyter_client, that should be done with a separate PR.

[rgbkrk]

Thank you all!