Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Inject session identifier into environment variable #924

Closed
wants to merge 3 commits into from

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Jul 14, 2022

Manual backport of #679 and #859.

Carreau and others added 3 commits July 13, 2022 10:38
There are many use case where users want to know the current notebook
name/path. This help by adding a session identifier (to not really say
this is the current notebook name), and by default make it the full path
to the notebook document that created the session.

This will of course not work if the notebook get renamed, but we can
tackle this later.

See also jupyter/jupyter_client#656,
jupyter/notebook#6180. It will need to be ported
to jupyter_server as well.

This is the mirror commit of
jupyter/notebook#6279 on main notebook.
* Make start_kernel env extend os.environ

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@vidartf
Copy link
Member Author

vidartf commented Jul 14, 2022

I thought I had already opened this, but couldn't find it, so apologies if this is a duplicate!

@vidartf vidartf closed this Jul 14, 2022
@vidartf
Copy link
Member Author

vidartf commented Jul 14, 2022

#920.

@vidartf vidartf deleted the backport-env branch July 14, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants