fix Can't open a directory named checkpoints #12408 #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastonsuo
changed the title
This was referenced Aug 18, 2022
|
Hey @eastonsuo, apologies that the team hasn't responded here. This has been a long standing issue in Jupyter-Server that requires a bit more nuanced work to allow these paths. Unfortunately, as this PR stands, it solves the immediate issue, but removes critical existing APIs. To fully address the issue, we'd need to think carefully about deprecating the old APIs and special-casing the checkpoints+trust endpoints. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#jupyterlab/jupyterlab#12408
Resolves: #950