[Batch 2] Notebook PR Ports. #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`exporter_map` is deprecated, so let's use the list of exporters fetched from the installed entrypoints. There's a supposed attribute `export_from_notebook` that should be set to a friendly string name if the exporter should be exposed in the front-end. However, the exporters defined in `nbconvert` don't have it set, so I haven't used it to determine inclusion in the list. Instead, I've used the entrypoint name as the friendly name, which looks like it was the intention from the way they are named. I ran the unit tests and tried starting up the notebook server and accessing the API endpoint to verify the JSON looked correct.
Although I'm unable to reproduce the issue, its a safe change to
prevent an AttributeError from occuring ('NoneType' object has no
attribute 'close'). The user that reported this is attempting to
launch a kernel and I believe the launch only partially completed
such that `kernel._activity_stream` did not get established.
(This occurred from Jupyter Enterprise Gateway where we deal with remote
kernel launches across resource-managed clusters, so things are a bit
more involved relative to kernel establishment.)
It's still (IMHO) unclear how the adaptation goes. Like does "adapting to protocol X.Y.Z." mean the end-result is X.Y.Z or what you got is X.Y.Z and it's X.Y.W after adaptation.
Then split the file into two files, one containing the metrics themselves, the other containing any function that have something to do with prometheus. Finally, Added new metrics into the prometheus.metrics file that represent the number of running terminals and added the functionality for that metric to be recorded in the terminal.api_handlers file.
|
No cleanup necessary. |
vidartf
reviewed
Sep 26, 2019
| @@ -1,18 +1,5 @@ | |||
| """ | |||
| Prometheus metrics exported by Jupyter Notebook Server | |||
| from ..prometheus.metrics import HTTP_REQUEST_DURATION_SECONDS | |||
vidartf
reviewed
Sep 26, 2019
| @@ -0,0 +1,24 @@ | |||
| from notebook.prometheus.metrics import HTTP_REQUEST_DURATION_SECONDS | |||
vidartf
reviewed
Sep 26, 2019
| @@ -26,6 +26,8 @@ | |||
| from jupyter_server._tz import utcnow, isoformat | |||
| from ipython_genutils.py3compat import getcwd | |||
|
|
|||
| from notebook.prometheus.metrics import KERNEL_CURRENTLY_RUNNING_TOTAL | |||
Merged
Zsailer
pushed a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* make provisioner ip configurable * bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge without reading Issue 96