Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to pass custom env variables to kernel #981

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Make it easier to pass custom env variables to kernel #981

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dc6f8a
Make it easier to pass custom env variables to kernel
divyansshhh Sep 22, 2022
72ec2c2
Fix typo
divyansshhh Sep 22, 2022
75ed036
Merge branch 'main' into feat/path-env-variable-kernel
divyansshhh Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion jupyter_server/services/sessions/sessionmanager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,14 +268,19 @@ async def create_session(
self._pending_sessions.remove(record)
return result

def get_kernel_env(self, path):
"""Return the environment variables that need to be set in the kernel"""
return {**os.environ, "JPY_SESSION_NAME": path}

async def start_kernel_for_session(self, session_id, path, name, type, kernel_name):
"""Start a new kernel for a given session."""
# allow contents manager to specify kernels cwd
kernel_path = await ensure_async(self.contents_manager.get_kernel_path(path=path))
kernel_env = self.get_kernel_env(path)
kernel_id = await self.kernel_manager.start_kernel(
path=kernel_path,
kernel_name=kernel_name,
env={**os.environ, "JPY_SESSION_NAME": path},
env=kernel_env,
)
return kernel_id

Expand Down