Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hatch for version #10

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Oct 12, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@dlqqq
Copy link
Collaborator

dlqqq commented Oct 13, 2022

@davidbrochart Thanks for the PR! This looks a lot more concise, and I'm happy to remove tbump as our versioning tool. Do we need to add these lines into pyproject.toml? This is from jupyter-server.

Screen Shot 2022-10-13 at 4 23 18 PM

@davidbrochart
Copy link
Contributor Author

Do we need to add these lines into pyproject.toml?

We already have them.

@davidbrochart davidbrochart merged commit c25d01d into jupyter-server:main Oct 17, 2022
@davidbrochart davidbrochart deleted the hatch_version branch October 17, 2022 06:20
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.05%. Comparing base (fc2e244) to head (67fd1cb).
Report is 61 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files           4        4           
  Lines         273      273           
  Branches       41       41           
=======================================
  Hits          224      224           
  Misses         37       37           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants