Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #11

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Cleanup #11

merged 1 commit into from
Oct 13, 2022

Conversation

davidbrochart
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Base: 82.05% // Head: 81.98% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (732754a) compared to base (fc2e244).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   82.05%   81.98%   -0.07%     
==========================================
  Files           4        4              
  Lines         273      272       -1     
  Branches       41       41              
==========================================
- Hits          224      223       -1     
  Misses         37       37              
  Partials       12       12              
Impacted Files Coverage Δ
jupyter_server_fileid/extension.py 47.61% <0.00%> (ø)
jupyter_server_fileid/manager.py 89.35% <85.71%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@dlqqq dlqqq merged commit 7f92c97 into jupyter-server:main Oct 13, 2022
@welcome
Copy link

welcome bot commented Oct 13, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@davidbrochart davidbrochart deleted the cleanup branch October 14, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants