Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen to ContentsManager save events #18

Merged
merged 4 commits into from
Oct 18, 2022

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Oct 18, 2022

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 78.34% // Head: 78.59% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (244260a) compared to base (56aec65).
Patch coverage: 65.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   78.34%   78.59%   +0.24%     
==========================================
  Files           5        5              
  Lines         351      369      +18     
  Branches       49       51       +2     
==========================================
+ Hits          275      290      +15     
- Misses         62       65       +3     
  Partials       14       14              
Impacted Files Coverage Δ
jupyter_server_fileid/extension.py 44.82% <16.66%> (-5.18%) ⬇️
jupyter_server_fileid/manager.py 88.60% <77.77%> (+0.88%) ⬆️
jupyter_server_fileid/pytest_plugin.py 97.91% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 18, 2022

Requires JS>=1.15: jupyter-server/jupyter_server@49dfe2e

@dlqqq dlqqq merged commit b17224a into jupyter-server:main Oct 18, 2022
@dlqqq dlqqq deleted the listen-to-save branch October 18, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants