Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix root dir to records in ArbitraryFileIdManager #34

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Oct 27, 2022

New behavior:

  • root_dir is always prefixed via os.path.join() before writing record in ArbitraryFileIdManager
  • get_path() always returns an API path, i.e. relative to root_dir and delimited by /

Closes #31.

@dlqqq dlqqq added the enhancement New feature or request label Oct 27, 2022
@dlqqq dlqqq merged commit 71c90c6 into jupyter-server:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prefix contents manager root to paths stored in ArbitraryFileIdManager
1 participant