-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cell execution_state #197
Add cell execution_state #197
Conversation
d5e0b3c
to
a1d5ea9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, especially given that jupyterlab/jupyterlab#16431 moves in this direction.
I think that merging this one does not preclude #227 from being merged.
Can we standardize that allowed values are running
(or executing
) and idle
?
I would like to avoid using busy
here as "busy" represents a couple of sub-states (like executing
, pending-input
, queued
). Of note jupyterlab/jupyterlab#16431 used running
but it was not released yet so we are not bound to it.
Actually only |
Yes, what I meant is that we probably should have some place to store source of truth for the enum values, this does not have to be addressed in this PR but would be good to settle on something soon. |
a1d5ea9
to
91c3b9a
Compare
I think this one is good to merge 🎉 |
Shall we merge this? |
Hearing no objections I am going to merge this one :) |
I will publish |
It looks like do not have sufficient rights to release (https://github.com/jupyter-server/jupyter_ydoc/actions/runs/10282910526/job/28455597267) @davidbrochart are you able to help here?
|
I opened follow-up #259 |
Sorry I'm off with a very limited access to Internet, I'll look at that in a week or so. |
No worries, I will try asking someone else on the server meeting tomorrow to get rights to release. Are you able to get a quick look at #259 so that I could release that in an alpha to unblock jupyterlab/jupyterlab#16651? |
Done, let me try and release |
Looks like |
Closes #169