-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement file ID service #244
Conversation
981f5ce
to
b36ed0d
Compare
42f23a8
to
5a683c6
Compare
I thought the Does Jupyverse have the notion of a source root or are all paths absolute from the git-go? Does it support non-filesystem-based content? (I suppose this is purely a matter of "plugging in" a different contents module.) |
Not yet, see #236.
There is currently only a filesystem-based contents plugin, but this is definitely coming. |
42c499a
to
a555dc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David. I hope its okay to provide some suggestions even while this is in draft mode.
Thanks for the comments Kevin! They are all very relevant, I'll make the suggested changes 👍 |
Out of curiosity, why not use |
For those of you who have the same questions as me, there doesn't seem to be a good solution across systems |
…ckground, add logger, handle modified files
a555dc1
to
d661f73
Compare
1b858b9
to
558a6d5
Compare
There is this error on server shutdown:
See these issues: |
96bcce1
to
7d87e5c
Compare
f09f61d
to
3c1825b
Compare
Co-authored-by: Wh1isper <9573586@qq.com>
This is the counterpart of jupyter-server-fileid.