Commits on Oct 18, 2017

1. Fix jupyter-server#262: JSONErrorsMixin not returning correct results …

   After Notebook 5.2.0 is installed, JSONErrorsMixin.write_error is
   used to convert errors into JSON responses.  Previously, Notebook's
   `@json_errors` decorator performed this action. Since the decorator's
   replacement, `APIHandler.write_error`, doesn't adequately set the
   `reason` field, other tests fail so its not sufficient to drop the
   use of JSONErrorsMixin.  As a result, JSONErrorsMixin now incorporates
   the appropriate code from `APIHandler.write_error` (in particular the
   setting of the `traceback` field) - in addition to appropriately
   setting the `reason` field.  This mixin should continue to be used
   in the handler class hierachy until `APIHandler` is fixed.
   
   I have tested these changes with Notebook 5.1.0 and 5.2.0 installed.

   

   kevin-bates committed Oct 18, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 9896a01
   • Browse repository at this point

   Copy the full SHA

   9896a01 View commit details

   Browse the repository at this point in the history