Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hoist __version__ #34

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 1, 2022

Yep. Just exports __version__.

It would be really nice to get some py.typed into this, as the scope isn't too large.

@welcome
Copy link

welcome bot commented Dec 1, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 94.04% // Head: 94.08% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (1fb7247) compared to base (037a561).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   94.04%   94.08%   +0.03%     
==========================================
  Files          11       12       +1     
  Lines         504      507       +3     
==========================================
+ Hits          474      477       +3     
  Misses         30       30              
Impacted Files Coverage Δ
pytest_jupyter/__init__.py 100.00% <100.00%> (ø)
pytest_jupyter/_version.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit cad7bc8 into jupyter-server:main Dec 1, 2022
@welcome
Copy link

welcome bot commented Dec 1, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants