Added grayscale image support in put_image_data and exposed image_smoothing_enabled attribute #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
martinRenou
requested changes
May 14, 2024
|
Thanks for the comments! Updated as per your suggestions. |
martinRenou
approved these changes
Sep 4, 2024
|
I made a mistake, will reopen your PR and credit you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In setting up ipycanvas to use in a long-term project I had a couple of options that I think could be beneficial to others.
Its my first time working directly with TypeScript/JavaScript so happy to have feedback on a better/preferred way to do what I did and especially on how to test it as I was not sure how to get it to use the forked version aside from installing directly from the github fork. I am happy to update as needed.