docs update tofor canvas.stroke(path2D) in drawing_paths.rst #356
Conversation
* add stroke(path: Path2D) form to canvas --------- Co-authored-by: Chris Lee-Messer <chris@lee-messer.net>
|
|
|
@martinRenou Oops, I probably have a git workflow mistake. I did not expect the PR to have all these different commits. I think I made a mistake pushing to my own master branch first. I I assume you squash those out when it comes time to accept. In the future, I'm guessing I should delete my current fork, and re-fork and do my PRs from a branch. |
|
Hmm, I just noticed the sinusoidal stroke is not being rendered in the read the docs output for drawing paths Is that a bug in my submission to ipycanvas itself? Or, is it in the the build process not updating to the latest package version? Let me know if there is something I can help fix. |
Indeed this is the reason you see all these commits. On my end I'm fine squashing.
Probably that should be best. Alternatively you can remove your master branch and force update your fork (don't do it quite yet as it would remove this PR): git branch -D master ## Probably need to run this from another branch than master
git fetch https://github.com/jupyter-widgets-contrib/ipycanvas master
git checkout master
git push -f https://github.com/cleemesser/ipycanvas master
There is probably an action I should take on the publishing to fix this. |
| @@ -6,7 +6,7 @@ There are two ways for creating and drawing a path in ipycanvas. | |||
| Using Path2D | |||
| ------------ | |||
|
|
|||
| You can define a Path2D given an SVG path. Note that once the path is created, it is read only, you cannot dynamically change the path value. This means they do not (yet) support Path2D methods like Path2D.move_to, draw_line, etc. | |||
| You can define a Path2D given an SVG path. Note that once the path is created, it is read only, you cannot dynamically change the path value. ``ipycanvas`` does not (yet) support Path2D methods like Path2D.move_to, draw_line, etc. | |||
There was a problem hiding this comment.
Was this based off my review from your other PR? I actually prefer the original version you came up with, I changed my mind
There was a problem hiding this comment.
Yes, I read that discussion and made the change. If you changed your mind, you can close this PR, and I will fix my fork.
Thanks for the git help.
There was a problem hiding this comment.
Sure thing! Thanks for your PRs!
Same docs for drawing paths as discussed