Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ipywidgets 8 #66

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Support ipywidgets 8 #66

merged 7 commits into from
Aug 23, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Aug 20, 2022

Since ipywidgets 8 final has now been released.

Still getting this error for now:

image

@jtpio
Copy link
Member Author

jtpio commented Aug 23, 2022

CI passes but still the same issue as above.

@martinRenou
Copy link
Collaborator

Thanks for starting this! ipytree is still using the old Backbone .extend. It probably needs updating. I'm on it :)

@martinRenou
Copy link
Collaborator

Seems to be working fine once modernized a bit:

Screenshot from 2022-08-23 16-29-48

@martinRenou
Copy link
Collaborator

There is still an issue when it comes to removing nodes (hence some node duplication in the screenshot)

@martinRenou martinRenou marked this pull request as ready for review August 23, 2022 14:47
@martinRenou martinRenou merged commit d11514a into jupyter-widgets-contrib:master Aug 23, 2022
@jtpio
Copy link
Member Author

jtpio commented Aug 23, 2022

nice thanks!

@jtpio jtpio deleted the ipywidgets-8 branch August 23, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @martinRenou