Update to ipywidgets 8 #282

ibdafna · 2021-12-07T03:50:10Z

Signed-off-by: Itay Dafna i.b.dafna@gmail.com

ibdafna · 2021-12-07T03:51:47Z

@martinRenou I seem to be getting an type issue in the ipywidgets library when compiling ipydatagrid, really odd:

/node_modules/@jupyter-widgets/base/lib/widget".WidgetView' has no exported member named 'InitializeParameters'. Did you mean 'IInitializeParameters'?

Wondering what's going on. Can you see anything off with my updates?

martinRenou · 2021-12-07T08:15:42Z

@ibdafna You should probably rename it to IInitializeParameters for it to compile. This structure has been renamed in jupyter-widgets/ipywidgets@5221e4d#diff-efb19099381ae8911dd7f69b015a0138d08da7164512c1ee112aa75100bc9be2R694

ibdafna · 2021-12-07T17:49:43Z

@ibdafna You should probably rename it to IInitializeParameters for it to compile. This structure has been renamed in jupyter-widgets/ipywidgets@5221e4d#diff-efb19099381ae8911dd7f69b015a0138d08da7164512c1ee112aa75100bc9be2R694

Yeah, I'm not sure why this is happening because it's coming from @jupyter-widgets/base package on the latest beta version. Perhaps the rename is not reflected in the release?

EDIT: quite silly of me - I didn't rename this in the extension file.

package.json

ibdafna · 2022-04-20T04:17:47Z

@martinRenou I took another stab at fixing the jest spyOn() issue. I get a more meaningful error message now and it seems to be related to our mock comm of the mock widget manager.

 FAIL  tests/js/datagrid.test.ts
  ● Test suite failed to run

    tests/js/datagrid.test.ts:37:29 - error TS2769: No overload matches this call.
      Overload 1 of 4, '(object: {}, method: never): SpyInstance<never, never>', gave the following error.
        Argument of type 'IClassicComm | undefined' is not assignable to parameter of type '{}'.
          Type 'undefined' is not assignable to type '{}'.
      Overload 2 of 4, '(object: {}, method: never): SpyInstance<never, never>', gave the following error.
        Argument of type 'IClassicComm | undefined' is not assignable to parameter of type '{}'.
          Type 'undefined' is not assignable to type '{}'.

    37     const mock = jest.spyOn(grid.model.comm, 'send');
                                   ~~~~~~~~~~~~~~~

Test Suites: 1 failed, 1 total
Tests:       0 total
Snapshots:   0 total
Time:        3.469 s```

https://github.com/bloomberg/ipydatagrid/blob/2540fcf8edc946c00c218537114830dc0ad16bf4/tests/js/testUtils.ts#L155-L218

jasongrout · 2022-08-25T05:06:35Z

setup.cfg

@@ -28,7 +28,7 @@ keywords = Jupyter, Widgets, IPython
 packages = find:
 install_requires =
 bqplot>=0.11.6
- ipywidgets>=7.6.0,<8
+ ipywidgets>=7.6.0


Suggested change

ipywidgets>=7.6.0

ipywidgets>=7.6.0,<9

ibdafna · 2022-08-25T06:35:28Z

galata update references

ibdafna · 2022-08-25T06:40:32Z

update galata references

ibdafna · 2022-08-25T06:42:43Z

update galata references

ibdafna · 2022-08-25T07:21:11Z

@martinRenou It seems like the Galata bot has updated the reference images with a images from a failed render attempt - they all show "error displaying widget model". The reference images are captures using ipywidgets 7, and testing locally with ipywidgetx 7.x works fine. Another thing to think about is that there we only capture reference images from one source - either the 7.x or 8.x environment. Should we think about extending the logic so we have separate images for both versions? Is it even reasonable to expect images to render (however slightly) differently between the two major versions?

ibdafna · 2022-08-25T17:08:06Z

update galata references

martinRenou · 2022-08-26T07:18:35Z

they all show "error displaying widget model". The reference images are captures using ipywidgets 7

Are you able to capture the JS outputs for those tests? Jason shared some nice debugging tricks with Galata here jupyter-widgets/ipyleaflet#968 (comment)

Is it even reasonable to expect images to render (however slightly) differently between the two major versions?

I guess it's reasonable.
I've seen a slight shift to the right for some outputs in ipympl and bqplot, but I bet it's due to some change in Galata or JupyterLab, not ipywidgets.

ibdafna · 2022-09-11T18:11:58Z

@martinRenou the visual regression tests are genuinely failing on ipywidgets 7.x. We didn't think about the JupyterLuminoPanelWidget imports in ipywidgets 7.x. I added a function with some ts-ignores, but it's still failing. Need to investigate further

ibdafna · 2022-09-28T16:33:18Z

update galata references

ibdafna · 2022-09-29T00:38:15Z

update galata references

ibdafna · 2022-09-29T00:45:11Z

update galata references

…sion Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Bumps [shell-quote](https://github.com/substack/node-shell-quote) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/substack/node-shell-quote/releases) - [Changelog](https://github.com/substack/node-shell-quote/blob/master/CHANGELOG.md) - [Commits](https://github.com/substack/node-shell-quote/compare/v1.7.2...1.7.3) --- updated-dependencies: - dependency-name: shell-quote dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Signed-off-by: Itay Dafna <idafna@seas.upenn.edu> Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

…sion Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

ibdafna · 2022-09-30T04:46:47Z

🎉🎊🥳

ibdafna marked this pull request as draft December 7, 2021 03:50

martinRenou reviewed Mar 3, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

ibdafna force-pushed the ipywidgets_8 branch from 9372a75 to a620ca8 Compare April 20, 2022 03:24

ibdafna force-pushed the ipywidgets_8 branch from 74a1ed3 to ff01dc1 Compare April 29, 2022 17:19

jtpio mentioned this pull request Aug 4, 2022

2022 Jupyter Widgets Dev Meetings jupyter-widgets/team-compass#13

Open

ibdafna force-pushed the ipywidgets_8 branch 2 times, most recently from 30e27ff to 0c2e839 Compare August 24, 2022 21:14

ibdafna marked this pull request as ready for review August 24, 2022 21:15

jasongrout reviewed Aug 25, 2022

View reviewed changes

ibdafna force-pushed the ipywidgets_8 branch from bbf3e4a to b926981 Compare August 25, 2022 05:24

ibdafna closed this Aug 25, 2022

ibdafna reopened this Aug 25, 2022

ibdafna force-pushed the ipywidgets_8 branch from 6f93cfe to b836c99 Compare September 11, 2022 18:13

ibdafna force-pushed the ipywidgets_8 branch from f087b0b to 618140c Compare September 28, 2022 16:33

ibdafna closed this Sep 28, 2022

ibdafna reopened this Sep 28, 2022

ibdafna and others added 23 commits September 29, 2022 14:26

Update widgets/base package, remove upper bound pin on ipywidgets ver…

edd67d3

…sion Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update test to reflect latest pandas version, update lockfile

ce3f021

Signed-off-by: Itay Dafna <idafna@seas.upenn.edu> Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update widgets/base package, remove upper bound pin on ipywidgets ver…

57e1268

…sion Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Fix Jest issues 🤎

0a641a5

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Add widget base 6 as dep

ac1c06e

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update package lockfile 🔒

1ce6cca

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Separate test suites for ipywidgets 7/8

584c84c

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update lockfile 🔒

3a2f09a

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Fix filenames, drop nodejs version to 14

0c26a2d

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update ipywidgets version to 8

7622cc6

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update ipywidgets version to 8

801f18c

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Appease linter

54518b0

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Fix pandas version in expected output object

9e07e26

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update Galata test env file name

85487aa

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Add old test environment file back

74b5005

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update Playwright Snapshots

77bd90c

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update Playwright Snapshots

fca4079

Split ui-testing for ipw7/8

b3e11da

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update venv names for split testing

e90475e

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update Playwright Snapshots

1e5b36c

Update lockfile

ba8251c

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

Update lockfile 🔑

3ee8a99

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>

ibdafna dismissed retadlock’s stale review via 3ee8a99 September 29, 2022 21:32

ibdafna force-pushed the ipywidgets_8 branch from f9430db to 3ee8a99 Compare September 29, 2022 21:32

retadlock approved these changes Sep 30, 2022

View reviewed changes

ibdafna merged commit 2ef8706 into jupyter-widgets:main Sep 30, 2022

ibdafna deleted the ipywidgets_8 branch September 30, 2022 04:46

maartenbreddels mentioned this pull request Feb 16, 2023

fix: do not share the Expr for text_color and background_color #400

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to ipywidgets 8 #282

Update to ipywidgets 8 #282

ibdafna commented Dec 7, 2021

ibdafna commented Dec 7, 2021

martinRenou commented Dec 7, 2021

ibdafna commented Dec 7, 2021 •

edited

Loading

ibdafna commented Apr 20, 2022

jasongrout Aug 25, 2022

ibdafna Aug 25, 2022

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

martinRenou commented Aug 26, 2022

ibdafna commented Sep 11, 2022

ibdafna commented Sep 28, 2022

ibdafna commented Sep 29, 2022

ibdafna commented Sep 29, 2022

ibdafna commented Sep 30, 2022

Update to ipywidgets 8 #282

Update to ipywidgets 8 #282

Conversation

ibdafna commented Dec 7, 2021

ibdafna commented Dec 7, 2021

martinRenou commented Dec 7, 2021

ibdafna commented Dec 7, 2021 • edited Loading

ibdafna commented Apr 20, 2022

jasongrout Aug 25, 2022

Choose a reason for hiding this comment

ibdafna Aug 25, 2022

Choose a reason for hiding this comment

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

ibdafna commented Aug 25, 2022

martinRenou commented Aug 26, 2022

ibdafna commented Sep 11, 2022

ibdafna commented Sep 28, 2022

ibdafna commented Sep 29, 2022

ibdafna commented Sep 29, 2022

ibdafna commented Sep 30, 2022

ibdafna commented Dec 7, 2021 •

edited

Loading